View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000001 | O3 Shop | General | public | 2023-03-05 12:53 | 2023-03-21 11:41 |
Reporter | mzanier | Assigned To | Ozone | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | resolved | Resolution | fixed | ||
Product Version | 1.0.0 | ||||
Target Version | 1.1.0 | ||||
Summary | 0000001: mysql version check in installer | ||||
Description | installer should check mysql compatibility, and thus not allow to use mysql 8 if not supported mysql 8 error SQLSTATE[42000]: Syntax error or access violation: 1305 FUNCTION oxid.ENCODE does not exist | ||||
Tags | installer | ||||
|
OxidEsales\EshopCommunity\Core\SystemRequirements::checkMysqlVersion() actually checks with the result from `SHOW VARIABLES LIKE 'version'`. Check whether the code is called or why the check was not successful. |
|
The issue is strange: There is a mySQL version check, but it only checks that the version is not below 5.5 and not 5.6. Higher is no longer checked, probably due to the different version numbers between mySQL and MariaDB. OXID wanted to outsource the check to a DatabaseCheck class 4 years ago (https://github.com/OXID-eSales/oxideshop_ce/blame/31030419b20fa70eae03d6d0bc41a5599e7aeef2/source/Core/SystemRequirements.php#L692), but adjusted the comment 3 months later without justification to remove the check completely (https://github.com/OXID-eSales/oxideshop_ce/blame/b-6.4.x/source/Core/SystemRequirements.php#L718). In fact, it will only be removed with the future 7.0. With "SELECT VERSION();" we should be able to check which type is installed and then specify the version check. |
|
implemented as DatabaseCheckerBridge service Database version requirement is displayed in the setup without being checked. As soon as access data to the database is available, the check runs exactly against - mySQL 5.5 or - mySQL 5.7 or - MariaDb 10.4 |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-03-05 12:53 | mzanier | New Issue | |
2023-03-05 12:53 | mzanier | Tag Attached: installer | |
2023-03-06 11:46 | Ozone | Note Added: 0000001 | |
2023-03-06 21:07 | Ozone | Note Added: 0000002 | |
2023-03-19 23:23 | Ozone | Note Edited: 0000002 | |
2023-03-20 00:58 | Ozone | Product Version | => 1.0.0 |
2023-03-20 00:58 | Ozone | Target Version | => 1.1.0 |
2023-03-21 11:37 | Ozone | Assigned To | => Ozone |
2023-03-21 11:37 | Ozone | Status | new => assigned |
2023-03-21 11:41 | Ozone | Status | assigned => resolved |
2023-03-21 11:41 | Ozone | Resolution | open => fixed |
2023-03-21 11:41 | Ozone | Note Added: 0000004 |